This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] - custom location engine fixes #9141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking great @LukasPaczos! Thank you for the contribution. I'm going to fix-up the formatting on this commit. For future reference we use the configuration found here. There isn't a link from the repo to the wiki so it's hard to discover. I added this to the todo documentation in #8390 (comment). |
|
@tobrun oh crap, I missed that, sorry! Will do better next time :) |
|
Bots are not starting when I push this branch to this repo, let's continue this in #9142 |
This was referenced Jun 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing issue from #9139