Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Label legibility improvements: pitch-scaling and pitched line-following #9009

Merged
merged 15 commits into from
Jul 11, 2017
Merged

Label legibility improvements: pitch-scaling and pitched line-following #9009

merged 15 commits into from
Jul 11, 2017

Commits on Jul 11, 2017

  1. [core] Improved label pitch-scaling: approximate collision box shapes… 

    … based on tile distance from camera.
    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    59df3a9 View commit details
    Browse the repository at this point in the history

  2. [core] Pass pitch-scaling vertex attributes and uniforms to shaders.

    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    8f5e0b6 View commit details
    Browse the repository at this point in the history

  3. [core] Extend collision feature boxes to accommodate potential pitch-… 

    …scaling.
    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    7b29b90 View commit details
    Browse the repository at this point in the history

  4. [core] Enable tile clipping for collision boxes. 

    Necessary because collision boxes now change shape based on while tile they're part of.
    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    2ee5979 View commit details
    Browse the repository at this point in the history

  5. [core] Set "max_camera_distance" to 1.5 for viewport-aligned road lab… 

    …els.

Viewport-aligned curved labels start to look very strange in the distance. Until we have a better system for projecting them, just prevent them from showing.
    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    f8402e2 View commit details
    Browse the repository at this point in the history

  6. [core] Use fade texture in collision debug boxes so that they agree m… 

    …ore closely with symbol shaders.
    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    8c23f14 View commit details
    Browse the repository at this point in the history

  7. [core] Re-generate shaders.

    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    7c7564d View commit details
    Browse the repository at this point in the history

  8. [core] Limit symbol re-placement on changed tile distance to pitch > 25.

    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    72f6b73 View commit details
    Browse the repository at this point in the history

  9. [core] Change OverscaledTileID to also include a "wrap" value. 

    This prevents TilePyramid from sharing wrapped copies of tiles.
This is necessary because two wrapped tiles no longer share the same CollisionTile.
    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    a432a28 View commit details
    Browse the repository at this point in the history

  10. [core] Hold on to tile yStretch value for rendering old symbolBuckets… 

    … while waiting for new ones.
    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    a0e37fe View commit details
    Browse the repository at this point in the history

  11. [core] fix transformMat4 

    It used to overwrite values in the middle of the calculation which would
cause problems when `out` and `a` were a reference to the same vector.
    @ansis
    ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    77734cf View commit details
    Browse the repository at this point in the history

  12. [core] improve legibility of labels that follow lines 

    port mapbox/mapbox-gl-js#4781

This improves legibility of labels that follow lines in pitched views.
The previous approach used the limited information in the shader to
calculate put the glyph in approximatelyright place. The new approach
does this more accurately by doing it on the cpu where we have access to
the entire line geometry.
    @ansis
    ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    e514138 View commit details
    Browse the repository at this point in the history

  13. [core] port pitch-label collision hack 

    mapbox/mapbox-gl-js@8136395
    @ansis
    ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    d661b4b View commit details
    Browse the repository at this point in the history

  14. [core] add static asserts for more gl constants 

    and rename BufferUsageType to BufferUsage
    @ansis
    ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    eac2971 View commit details
    Browse the repository at this point in the history

  15. [test] Bump mapbox-gl-js version to re-enable pitched tests

    @ChrisLoer @ansis
    ChrisLoer authored and ansis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    4f63a39 View commit details
    Browse the repository at this point in the history