This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Update callout/popover when relocating annotation #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When relocating a selected point annotation, update the associated callout (popover) rather than deselecting the annotation.
1ec5
added
annotations
|
@1ec5, thanks for your PR! By analyzing this pull request, we identified @boundsj, @incanus and @friedbunny to be potential reviewers. |
frederoni
approved these changes
Mar 3, 2017
|
FYI the historical reason here was because SMCalloutView (when we used it) required a re-layout since it weights left or right when near the screen edges. |
|
We still use SMCalloutView, and it’s true that the anchor will remain weighted based on the original location on screen. But this affects all callouts, including the user dot’s callout. Due to how SMCalloutView encapsulates its layout code but doesn’t support dynamic layout, a fix would essentially entail replacing SMCalloutView with something better (#4392), since at that point we’d be unable to use almost anything that SMCalloutView provides as-is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When relocating a selected point annotation, update the associated callout (iOS) or popover (macOS) to reflect the annotation’s new coordinates rather than deselecting the annotation.
Fixes #6284.
/cc @frederoni