This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Added basic notes about using Carthage #8257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@friedbunny, thanks for your PR! By analyzing this pull request, we identified @zugaldia, @tmcw and @1ec5 to be potential reviewers. |
friedbunny
force-pushed
the
fb-carthage-instructions
branch
from
07c5893
to
c7be460
Compare
1ec5
reviewed
Mar 3, 2017
platform/ios/CHANGELOG.md
Outdated
| @@ -47,6 +47,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
| ### Other changes | |||
|
|
|||
| * The minimum deployment target for this SDK is now iOS 8. ([#8129](https://github.com/mapbox/mapbox-gl-native/pull/8129)) | |||
| * Added support for the Carthage dependency manager. See [our website](https://www.mapbox.com/ios-sdk/) for setup instructions. ([#8257](https://github.com/mapbox/mapbox-gl-native/pull/8257)) | |||
There was a problem hiding this comment.
Remember not to add this blurb to the release notes until the final release, at least until Carthage/Carthage#1553 lands.
There was a problem hiding this comment.
Good point. 👍
/cc @boundsj
1ec5
approved these changes
Mar 3, 2017
1ec5
changed the title
friedbunny
force-pushed
the
fb-carthage-instructions
branch
from
1e14834
to
8f89275
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1623.
Does not address macOS.@1ec5 added macOS instructions.