Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] - add accessibility support to the Android SDK #8230

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Mar 1, 2017

This PR optimises accessibility support for TalkBack by applying content description to all overlain View elements and removing setClickable(true) and setLongClickable(true) (these flags introduced some additional talkback responses while the map also works correctly without).

I have been looking into using an AccesibilityDelegate but it seems that they only support a limited amount of gestures. (click, longclick) and it's not possible to add custom ones. To work around this I added mapbox_mapActionDescription which has a similar structure as the one generated by AccessibilityDelegateCompat.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Mar 1, 2017
@tobrun tobrun added this to the android-v5.0.0 milestone Mar 1, 2017
@tobrun tobrun self-assigned this Mar 1, 2017
@tobrun tobrun requested a review from zugaldia March 1, 2017 00:42
@mention-bot
Copy link

@tobrun, thanks for your PR! By analyzing this pull request, we identified @tmcw, @zugaldia and @ansis to be potential reviewers.

Copy link
Member

@zugaldia zugaldia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, let's merge and double check that setClickable(true);, setLongClickable(true); aren't needed.

…content descriptions on Views overlain on the map.
@tobrun tobrun force-pushed the 4857-accessibility-support branch from 7c9d8a6 to e6f497c Compare March 1, 2017 21:14
@tobrun tobrun merged commit ef82095 into master Mar 1, 2017
@tobrun tobrun deleted the 4857-accessibility-support branch March 1, 2017 22:07
@1ec5 1ec5 added the accessibility Integration with screen readers and other assistive technology label Mar 4, 2017
@zugaldia zugaldia mentioned this pull request Mar 10, 2017
8 tasks
@tobrun tobrun mentioned this pull request Mar 17, 2017
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Integration with screen readers and other assistive technology Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants