This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Split NSValue+MGLStyleEnumAttributeAdditions category per style layer type #7576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
iOS
|
@1ec5, thanks for your PR! By analyzing this pull request, we identified @boundsj, @incanus and @friedbunny to be potential reviewers. |
boundsj
approved these changes
Jan 3, 2017
|
In 3fb2489, I decided to move the categories into their respective style layer headers, so that they’d be closer to the enumeration declarations. (It also simplifies the code a bit.) Unfortunately, that change triggers realm/jazzy#539: now all the declarations are under “NSValue (MGLCircleStyleLayerAdditions)”. Unless I find a fix for the upstream issue, I’ll revert the change and leave it for another day. |
|
A fix for the upstream issue is in realm/jazzy#719:
|
…r style layer type Also renamed the file to have a slightly more wieldy name.
…ations Eliminated the separate NSValue+MGLStyleLayerAddition files, moving the categories into their respective style layer headers to be closer to the enumeration declarations.
1ec5
force-pushed
the
1ec5-style-enum-value-categories
branch
from
3fb2489
to
fa2035b
Compare
|
Merging now that realm/jazzy#719 has landed. We’ll have to make sure to generate the documentation using jazzy on master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the NSValue+MGLStyleEnumAttributeAdditions category into one category for each style layer type and renamed the category files to have a slightly more wieldy name.