This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Restore -Werror #6487
Merged
Restore -Werror #6487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkaefer, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @tmpsantos and @springmeyer to be potential reviewers. |
Closed
kkaefer
force-pushed
the
6487-werror
branch
from
13c1c4d
to
40c9088
Compare
jfirebaugh
approved these changes
Sep 28, 2016
kkaefer
force-pushed
the
6487-werror
branch
from
40c9088
to
a98812d
Compare
kkaefer
force-pushed
the
6487-werror
branch
from
a98812d
to
91bc2a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to treat all warnings as errors with
-Werror. I think this was lost with the switch to CMake; we should restore it.