-
Notifications
You must be signed in to change notification settings - Fork 1.3k
render to a single static context in HeadlessView #6278
Conversation
@mikemorris, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh and @tmpsantos to be potential reviewers. |
5cc42fa
to
6b4c01d
Compare
6b4c01d
to
c989b96
Compare
Does this
|
This looks like a bit more complex issue, directly related to this pull request. The Node.js and QT builds are actually passing, seeing this segfault on all the GLFW builds however.
|
GLXFBConfig *fbConfigs = nullptr; | ||
GLXContext glContext = nullptr; | ||
GLXPbuffer glxPbuffer = 0; | ||
static Display *xDisplay; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capturing from our chat, these static
are probable why it is crashing on GLFW.
Closing; sharing contexts between maps should be handled by sharing a single |
Fixes #6212
This is a first draft. It would be worth investigating whether
needsResize
can be refactored intoHeadlessView::resize
, eliminating the need forHeadlessView::activate
- if possible we could completely remove that method andHeadlessView::deactivate
, which is just a no-op for now.Is it necessary to deactivate and destroy the
glContext
anywhere now that it'sstatic
and shared across all instances ofHeadlessView
?/cc @tmpsantos