This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add custom @2x handling for mapbox v4 tile API when tileSize: 512 #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| versionIdx != std::string::npos && | ||
| (normalizedURL.compare(extensionIdx + 1, 3, "png") == 0 || | ||
| normalizedURL.compare(extensionIdx + 1, 3, "jpg") == 0 || | ||
| normalizedURL.compare(extensionIdx + 1, 4, "webp") == 0)) { |
There was a problem hiding this comment.
A better comparison would be add this function to string.hpp:
inline bool beginsWith(const std::string& string, const std::string &prefix) {
return std::equal(prefix.begin(), prefix.end(), string.begin());
}
|
Can we hold this until after #3715 lands? There's going to be significant conflicts. |
👍 |
jfirebaugh
force-pushed
the
tileSize512
branch
from
c0cfc8a
to
f25a873
Compare
|
Updated for today's new offline world. @yhahn @tmpsantos Look good? |
👍 |
jfirebaugh
force-pushed
the
tileSize512
branch
from
f25a873
to
43c44ec
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native port of mapbox/mapbox-gl-js#2044.
cc @jfirebaugh @kkaefer @brunoabinader