This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Increment the schema version #3733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to 1c21d0f. Prior to that commit, resources without an expiration were stored with an expiration column value of 0. After it, they are stored with a null column value. Without a schema increment, existing resources in the cache with a 0 value would be treated as expiring at the epoch, causing endless revalidation.
|
Obsoleted by #3715. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to 1c21d0f. Prior to that commit, resources without an expiration were stored with an expiration column value of 0. After it, they are stored with a null column value. Without a schema increment, existing resources in the cache with a 0 value would be treated as expiring at the epoch, causing endless revalidation.
cc @bleege