don't scale when adding to sprite atlas

[ansis]

Don't scale images when adding them to the sprite atlas and make the sprite atlas match -js.

fix #3164 and port https://github.com/mapbox/mapbox-gl-js/pull/1919/files

can you review @jfirebaugh?

[jfirebaugh]

Also fixes #3513?

[mb12]

@ansis Can SpriteAtlas::bind be unconditionally called with linear=true?

[jfirebaugh]

What about this scaling code?

[ansis]

Also fixes #3513?

Yes, except for #3528

@ansis Can SpriteAtlas::bind be unconditionally called with linear=true?

Using nearest neighbour filtering is clearer when icons copied at their original size. This small bit of extra clarity matters since icons are already pretty small.

What about this scaling code?

yeah, that needs to be removed.

[ansis]

The nearest neighbour scaling code is removed in fc20199

[ansis]

@jfirebaugh I think this should be good now. Want to take another look?

[jfirebaugh]

?

[ansis]

oh, good catch. I'll remove and add a render test to catch this kind of bug: mapbox/mapbox-gl-test-suite#72

[ansis]

scaling.hpp is removed in 0930972

the wrapping bug is fixed in e16a487 and covered with a new render test: mapbox/mapbox-gl-test-suite@a7e5668

do you see anything else or can this be squashed and merged (once tests ci passes)?

[jfirebaugh]

LGTM