Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

iOS Customize Callout Content #3013

Closed

Conversation

mappy-mobile
Copy link

Add the ability to customize callout views content via the mapView:calloutViewForAnnotation: callback of MGLMapViewDelegate.

@incanus incanus added feature iOS Mapbox Maps SDK for iOS labels Nov 12, 2015
@friedbunny
Copy link
Contributor

This would fix #2211.

@mappy-mobile
Copy link
Author

I didn't mention issue #2211 because it seems to me that was about totally replacing the callout view.
Maybe both systems can be implemented :

My callback could be renamed to 'calloutContentViewForAnnotation' and we could add a 'calloutViewForAnnotation' for the first use case ?

@friedbunny
Copy link
Contributor

@mappy-mobile Ah yes, you're totally right —calloutViewForAnnotation threw me, at first glance.

I think our intention should still be to allow complete replacement of the callout view (#2211), but calloutContentViewForAnnotation/centerCalloutContentView (this PR) may also be useful.

/cc @incanus @1ec5

@1ec5
Copy link
Contributor

1ec5 commented Sep 6, 2016

Thank you for the pull request! We’re overhauling the callout API in #4948 to remove the SMCalloutView dependency. I’m not sure if we want to allow a halfway-custom callout view in the new API, but let’s see whether the implementation lends itself to something like that.

@1ec5 1ec5 closed this Sep 6, 2016
@mappy-mobile mappy-mobile deleted the ios_customize_callout_content branch January 15, 2018 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants