This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[test runner] Support independent tile rendering in tile mode #16068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
force-pushed
the
mikhail_render_test_tile_mode
branch
from
f0c0875
to
b6b5fcb
Compare
pozdnyakov
force-pushed
the
mikhail_render_test_tile_mode
branch
from
b6b5fcb
to
b7b6a0b
Compare
| LatLng getTileCenterCoordinates(const UnwrappedTileID& tileId) { | ||
| double scale = (1 << tileId.canonical.z) / util::tileSize; | ||
| Point<double> tileCenter{tileId.canonical.x + 0.5, tileId.canonical.y + 0.5}; | ||
| return Projection::unproject(tileCenter, scale); |
There was a problem hiding this comment.
Projection::unproject expects position values to be in world coordinates (or is it called pixel coordinates?) Would it make more sense to multiply tileCenter with 1 << tileId.canonical.z rather than dividing the scale value with util::tileSize?
pozdnyakov
force-pushed
the
mikhail_render_test_tile_mode
branch
from
b7b6a0b
to
8f1bbfc
Compare
mpulkki-mapbox
approved these changes
Dec 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables test runner rendering tiles independently in tile mode, so that the issues on tile boundaries can be discovered (pls see below).
This change is applicable for all render tests with
mapModeoption set totile, i.e.Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/94
cc @springmeyer @mapbox/static-apis