This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Check if pattern dependencies or pattern positions are missing #14696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
approved these changes
May 17, 2019
Add check for optional pattern dependencies and don't bind empty vertex buffers if pattern positions are missing.
alexshalamov
force-pushed
the
alexshalamov_fix_for_14518
branch
from
068af74
to
46d5f5e
Compare
astojilj
approved these changes
May 20, 2019
friedbunny
added
Core
|
Thanks for tracking this down, @alexshalamov! Since this fixed a crash, it should receive an entry in the platform changelogs. |
friedbunny
removed
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for optional pattern dependencies and don't bind empty vertex buffers if pattern positions are missing.
Fixes: #14518