This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[darwin] Fix direction wrapping #14082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
bug
iOS
brunoabinader
approved these changes
Mar 12, 2019
1ec5
approved these changes
Mar 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14073 by re-adding the 0-to-360° wrapping for
MGLMapView.directionthat was removed in #14017. Without this wrapping, we’d get ±180° from core, which results in invalidCLLocationDirectionfor the negative half of the rotational spectrum.This is a two line fix that adds a variety of tests to confirm that the iOS rotation gesture and compass rotation are correct.
/cc @brunoabinader @1ec5