Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Force attribution, title-casing tests to pass #13387

Closed
wants to merge 3 commits into from
Closed

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Nov 16, 2018

This is a followup to #11391 that ensures the attribution and title-casing tests pass on iOS and macOS regardless of system version or locale. The changes include a workaround for an AppKit bug and a hard-coded locale identifier (for folks like me who run macOS or iOS in a language other than English).

Fixes #13386.

/cc @julianrex @friedbunny

Fixed a title-casing test when run in a non-English locale. The test was written only for English anyways.
@1ec5 1ec5 added macOS Mapbox Maps SDK for macOS tests runtime styling labels Nov 16, 2018
@1ec5 1ec5 added this to the release-iowaska milestone Nov 16, 2018
@1ec5 1ec5 self-assigned this Nov 16, 2018
@1ec5 1ec5 added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Nov 16, 2018
@1ec5 1ec5 removed this from the release-iowaska milestone Dec 18, 2018
@stale stale bot added the archived Archived because of inactivity label Feb 16, 2019
@stale
Copy link

stale bot commented Feb 17, 2019

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold macOS Mapbox Maps SDK for macOS runtime styling tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants