This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix MGLMapSnapshotter concurrency bugs (issue #11827). #11831
Merged
Commits on Jun 1, 2018
-
[ios, macos] Fix MGLMapSnapshotter concurrency bugs (issue #11827).
- Biggest change: when we apply the watermark on a background thread, don't capture self (turn most of the related instance methods into class methods) - Don't call mbglMapSnapshotter->snapshot from a user-provided queue, since it's an asynchronous call anyway and starting it on the user's queue requires capturing self.
-
-
[ios, macos] Raise exception if MGLMapSnapshotter is used from thread…
… without active run loop.
-
-
[test,ios] Disable multiple mapsnapshotter test.
8 simultaneous mapsnapshotter test periodically deadlocks in simulator. Also, increase timeouts to decrease chance of spurious test failure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.