Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Fix C++ symbol visibility warnings in test suite #10684

Merged
merged 1 commit into from
Dec 15, 2017
Merged

[ios] Fix C++ symbol visibility warnings in test suite #10684

merged 1 commit into from
Dec 15, 2017

Conversation

akitchen
Copy link
Contributor

Fixes #10656

@friedbunny
Copy link
Contributor

This does cause the warnings to go away, but I’m not clear on why we only started encountering this now — what is MGLFillStyleLayerTests doing that other generated style tests aren’t?

@kkaefer
Copy link
Contributor

kkaefer commented Dec 12, 2017

iOS visibility settings changed as part of the standardization in #10592

@kkaefer kkaefer added build iOS Mapbox Maps SDK for iOS labels Dec 13, 2017
@akitchen akitchen merged commit 9b9cfd9 into master Dec 15, 2017
@akitchen akitchen deleted the fix-visibility-warnings branch December 15, 2017 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@friedbunny friedbunny friedbunny approved these changes

@kkaefer kkaefer Awaiting requested review from kkaefer

Assignees
No one assigned
Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akitchen @friedbunny @kkaefer