Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update symbol layer example with location #10092

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Sep 29, 2017

This PR updates our SymbolLayer example with updating the symbol location.

ezgif com-video-to-gif 36

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Sep 29, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Sep 29, 2017
@tobrun tobrun self-assigned this Sep 29, 2017
@tobrun tobrun changed the title [android] - update symbol layer example with changing symbol location Update symbol layer example with location Sep 29, 2017
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor detail.

@@ -119,7 +128,8 @@ public void onMapClick(@NonNull LatLng point) {
if (!featureList.isEmpty()) {
Feature feature = featureList.get(0);
boolean isSelected = feature.getBooleanProperty(KEY_PROPERTY_SELECTED);
updateSource(!isSelected);
ZoomFunctionSymbolLayerActivity.this.isSelected = !isSelected;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing the name of the local isSelected variable so you don't need to be explicit (ZoomFunctionSymbolLayerActivity.this.isSelected)? Maybe isFeatureSelected?

@tobrun tobrun force-pushed the tvn-update-symbollayer-example branch from f19413e to dd28087 Compare October 2, 2017 08:17
@tobrun tobrun merged commit 6a846ce into master Oct 4, 2017
@tobrun tobrun deleted the tvn-update-symbollayer-example branch October 4, 2017 13:20
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
This was referenced Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants