Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Increase glyph atlas capacity #3781

Closed
ansis opened this issue Feb 1, 2016 · 5 comments · Fixed by #9213
Closed

Increase glyph atlas capacity #3781

ansis opened this issue Feb 1, 2016 · 5 comments · Fixed by #9213
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS

Comments

@ansis
Copy link
Contributor

ansis commented Feb 1, 2016

@bhousel could you port mapbox/mapbox-gl-js#1923 to -native?

@bhousel
Copy link
Contributor

bhousel commented Feb 1, 2016

sounds fun!

@mb12
Copy link

mb12 commented Feb 1, 2016

@ansis and @bhousel

1.) Is there any plan to do similar optimization for SpriteAtlas? Recently the size of SpriteAtlas was statically increased to 1024x1024. A similar improvement would allow the sprite atlas to be smaller for common use cases.
2.)
Also for GlyphAtals does the improvement also included shrinking the size dynamically?

@bhousel
Copy link
Contributor

bhousel commented Feb 1, 2016

Is there any plan to do similar optimization for SpriteAtlas?

Yes this is in my queue also.

Also for GlyphAtals does the improvement also included shrinking the size dynamically?

The current plan is to refcount the glyphs so that we can replace them when they are not referenced by visible tiles. I hadn't considered shrinking the atlas texture, but it's a possibility. Something like that would likely only occur if the map navigates from a place where CJK languages are in use to one where they are not - so I'm not sure how aggressively we want to optimize this.

@mb12
Copy link

mb12 commented Feb 1, 2016

@bhousel Thanks for the clarification. The ability to shrink the size automatically would be more useful for SpriteAtlas that houses user defined marker icons.

tobrun added a commit that referenced this issue Feb 11, 2016
tobrun added a commit that referenced this issue Feb 15, 2016
[android] #3781 #3899 - add map padding, user location view, ViewSettings, TrackingSettings

[android] #3761 - update map padding sample

[android] #3761 - add map padding
@1ec5
Copy link
Contributor

1ec5 commented May 18, 2016

I hadn't considered shrinking the atlas texture, but it's a possibility. Something like that would likely only occur if the map navigates from a place where CJK languages are in use to one where they are not - so I'm not sure how aggressively we want to optimize this.

Without cleaning up the textures, we’d exacerbate #1681, right?

@1ec5 1ec5 added the GL JS parity For feature parity with Mapbox GL JS label May 18, 2016
@jfirebaugh jfirebaugh changed the title port glyph atlas improvements Increase glyph atlas capacity Sep 27, 2016
@jfirebaugh jfirebaugh added the Core The cross-platform C++ core, aka mbgl label Sep 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants