Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Commit

Permalink
[ios,macos] Revert ideographic->ideograph name change.
Browse files Browse the repository at this point in the history
Original GL JS name was meant to represent "font family to use for locally generating ideographs", but "ideographic font family" communicates a similar intent more concisely.
  • Loading branch information
ChrisLoer authored and fabian-guerra committed Jan 2, 2018
1 parent 9b5aa61 commit 31d20aa
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion platform/darwin/src/MGLRendererConfiguration.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ NS_ASSUME_NONNULL_BEGIN
Currently only used for CJK glyphs. Changing this at run time is not currently
supported. Enable client-side rendering of CJK glyphs by setting
`MGLIdeographFontFamilyName` in your containing app's Info.plist to a value
`MGLIdeographicFontFamilyName` in your containing app's Info.plist to a value
which will be available at run time, e.g. "PingFang". */
@property (nonatomic, readonly) mbgl::optional<std::string> localFontFamilyName;

Expand Down
2 changes: 1 addition & 1 deletion platform/darwin/src/MGLRendererConfiguration.mm
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ - (const float)scaleFactor {
}

- (mbgl::optional<std::string>)localFontFamilyName {
NSString *fontFamilyName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"MGLIdeographFontFamilyName"];
NSString *fontFamilyName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"MGLIdeographicFontFamilyName"];

return fontFamilyName ? std::string([fontFamilyName UTF8String]) : mbgl::optional<std::string>();
}
Expand Down
2 changes: 1 addition & 1 deletion platform/ios/app/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<string>7877</string>
<key>LSRequiresIPhoneOS</key>
<true/>
<key>MGLIdeographFontFamilyName</key>
<key>MGLIdeographicFontFamilyName</key>
<string>PingFang</string>
<key>NSHumanReadableCopyright</key>
<string>© 2014–2017 Mapbox</string>
Expand Down
2 changes: 1 addition & 1 deletion platform/ios/docs/guides/Info.plist Keys.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ The default value is `https://api.mapbox.com`.

If you have implemented custom opt-out of Mapbox Telemetry within the user interface of your app, use this key to disable the built-in check for opt-out support. See [this guide](https://www.mapbox.com/ios-sdk/#telemetry_opt_out) for more details.

## MGLIdeographFontFamilyName
## MGLIdeographicFontFamilyName

The name of the font family to use for client-side text rendering of CJK ideographs. Set this to the name of a font family which will be available at run time, e.g. `PingFang`.
4 changes: 2 additions & 2 deletions platform/macos/docs/guides/Info.plist Keys.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ Use this key if you need to customize the API base URL used throughout the SDK.

The default value is `https://api.mapbox.com`.

## MGLIdeographFontFamilyName
## MGLIdeographicFontFamilyName

The name of the font family to use for client-side text rendering of CJK ideographs. Set this to the name of a font family which will be available at run time, e.g. `PingFang`.

0 comments on commit 31d20aa

Please sign in to comment.