This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add query integration test #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2020
|
Noting that I'm seeing a few failing integration tests on |
jmkiley
reviewed
Jun 22, 2020
| <EnvironmentVariables> | ||
| <EnvironmentVariable | ||
| key = "MAPBOX_ACCESS_TOKEN" | ||
| value = "pk.eyJ1IjoianVsaWFucmV4IiwiYSI6ImNrMGp2N3k3ZzAwbWkzbnMzcG1zZ291cmkifQ.6Fv-dxHmzcqHHm_Tlf3x6A" |
There was a problem hiding this comment.
Do we want to hard code a real access token here? Can we use the same script that iosapp uses to pull in the access token from ~/.mapbox?
There was a problem hiding this comment.
Oops! Yeah, that shouldn't be there. Can you remove please? And rebase the other PRs
There was a problem hiding this comment.
For future reference - this access token has been revoked.
captainbarbosa
approved these changes
Jul 6, 2020
* Port tests from gl-native 14324 * Port accessibility calcs * Fix typo from merge. * Match results from before optimization. * Remove temp commented code * Address some TODOs * Include exception from failing test Co-authored-by: jmkiley <jordan.kiley@mapbox.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of 3 PRs that port mapbox/mapbox-gl-native#15303 to this repo. (See also #318, #319.)
This PR adds a query test, but primarily adds a regression test for comparing accessibility elements - to track improvements to
accessibilityElementAtIndex:. See #220 for the original issue.