-
Notifications
You must be signed in to change notification settings - Fork 122
Conversation
Noting that I'm seeing a few failing integration tests on |
<EnvironmentVariables> | ||
<EnvironmentVariable | ||
key = "MAPBOX_ACCESS_TOKEN" | ||
value = "pk.eyJ1IjoianVsaWFucmV4IiwiYSI6ImNrMGp2N3k3ZzAwbWkzbnMzcG1zZ291cmkifQ.6Fv-dxHmzcqHHm_Tlf3x6A" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to hard code a real access token here? Can we use the same script that iosapp uses to pull in the access token from ~/.mapbox
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Yeah, that shouldn't be there. Can you remove please? And rebase the other PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference - this access token has been revoked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ once the conflicts are fixed
* Port tests from gl-native 14324 * Port accessibility calcs * Fix typo from merge. * Match results from before optimization. * Remove temp commented code * Address some TODOs * Include exception from failing test Co-authored-by: jmkiley <jordan.kiley@mapbox.com>
This is part 1 of 3 PRs that port mapbox/mapbox-gl-native#15303 to this repo. (See also #318, #319.)
This PR adds a query test, but primarily adds a regression test for comparing accessibility elements - to track improvements to
accessibilityElementAtIndex:
. See #220 for the original issue.