Mapbox GL Native v1.6.0-rc.2

[1ec5]

Upgraded to master of mapbox-gl-native in preparation for mbgl v1.6.0-rc.2. In addition to the usual submodule update, this PR unsuppresses the circle-sort-key property, removing the override added in mapbox/mapbox-gl-native#15008.

Changelog entries as of writing:

• Added the MGLCircleStyleLayer.circleSortKey property. ([core] Enable circle-sort-key property mapbox-gl-native#15875)
• Fixed a crash when calling the -[MGLStyle removeImageForName:] method with the name of a nonexistent image. (When removing an image use the correct list ptr for presence verification mapbox-gl-native#16391)
• Fixed a crash when encountering an invalid polyline. (Fix segfault resulting from an invalid geometry. mapbox-gl-native#16409)
• Certain logging statements no longer run on the main thread. (Move logging off the main thread mapbox-gl-native#16325)

Changelog entries for macOS:

• Fixed various crashes, including crashes on launch, on macOS 10.11.0 through 10.14.x. (Fix macOS minimum deployment target mapbox-gl-native#16412)

Additional changelog entries expected by the time v1.6.0-rc.2 comes out:

• The MGLIdeographicFontFamilyName Info.plist key now also accepts an array of font family names, to customize font fallback behavior. It can also be set to a Boolean value of NO to force the SDK to typeset CJK characters in a remote font specified by MGLSymbolStyleLayer.textFontNames. ([ios, macos] Default to local rendering of CJK characters, using system font mapbox-gl-native#14862)
• The MGLIdeographicFontFamilyName Info.plist key can now be set to the display names or PostScript names of individual fonts. (Allow specifying multiple fonts or font families for local font rendering #189)

/cc @mapbox/maps-ios

[1ec5]

mapbox/mapbox-gl-native#16340 introduced a couple compiler errors in mbgl-core:

▸ Compiling render_location_indicator_layer.cpp



❌  /Users/distiller/project/vendor/mapbox-gl-native/src/mbgl/renderer/layers/render_location_indicator_layer.cpp:617:66: implicit conversion loses integer precision: 'std::__1::array::size_type' (aka 'unsigned long') to 'mbgl::platform::GLsizei' (aka 'int') [-Werror,-Wshorten-64-to-32]



        MBGL_CHECK_ERROR(glDrawArrays(GL_TRIANGLE_FAN, 0, circle.size()));

                         ~~~~~~~~~~~~                     ~~~~~~~^~~~~~







❌  /Users/distiller/project/vendor/mapbox-gl-native/src/mbgl/renderer/layers/render_location_indicator_layer.cpp:621:75: implicit conversion loses integer precision: 'unsigned long' to 'mbgl::platform::GLsizei' (aka 'int') [-Werror,-Wshorten-64-to-32]



            MBGL_CHECK_ERROR(glDrawArrays(GL_LINE_STRIP, 1, circle.size() - 1));

I wonder why these -Wshorten-64-to-32 errors aren’t failing any builds in the mapbox-gl-native repository but fail here when the same CMake-generated mbgl project is built as part of the iOS map SDK workspace.

/cc @mapbox/gl-native

[galinelle]

mapbox/mapbox-gl-native#16340 introduced a couple compiler errors in mbgl-core:

▸ Compiling render_location_indicator_layer.cpp



❌  /Users/distiller/project/vendor/mapbox-gl-native/src/mbgl/renderer/layers/render_location_indicator_layer.cpp:617:66: implicit conversion loses integer precision: 'std::__1::array::size_type' (aka 'unsigned long') to 'mbgl::platform::GLsizei' (aka 'int') [-Werror,-Wshorten-64-to-32]



        MBGL_CHECK_ERROR(glDrawArrays(GL_TRIANGLE_FAN, 0, circle.size()));

                         ~~~~~~~~~~~~                     ~~~~~~~^~~~~~







❌  /Users/distiller/project/vendor/mapbox-gl-native/src/mbgl/renderer/layers/render_location_indicator_layer.cpp:621:75: implicit conversion loses integer precision: 'unsigned long' to 'mbgl::platform::GLsizei' (aka 'int') [-Werror,-Wshorten-64-to-32]



            MBGL_CHECK_ERROR(glDrawArrays(GL_LINE_STRIP, 1, circle.size() - 1));

I wonder why these -Wshorten-64-to-32 errors aren’t failing any builds in the mapbox-gl-native repository but fail here when the same CMake-generated mbgl project is built as part of the iOS map SDK workspace.

/cc @mapbox/gl-native

This should be an issue for https://github.com/mapbox/mapbox-gl-native-team/issues/272 rather?

[1ec5]

mapbox/mapbox-gl-native#16413 will fix the build error.

[fabian-guerra]

👍🏼