Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Notarize macosapp #204

Closed
wants to merge 1 commit into from
Closed

Notarize macosapp #204

wants to merge 1 commit into from

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Mar 10, 2020

Notarize macosapp when packaging a release of the macOS map SDK, so macOS users can more easily open the application without jumping through Gatekeeper hoops.

To do:

  • Opt into notarization when using ExportOptions.plist
  • Add the Hardened Runtime entitlement to the project
  • Set ENABLE_HARDENED_RUNTIME=YES in invocations of xcodebuild in package.sh (as opposed to inside the project, so non–Mapbox team members can continue to build ad-hoc)
  • Add a post-archive action to the scheme that exports the application for notarization
  • Invoke xcrun altool in package.sh
  • Split out a separate make rule that invokes xcrun stapler staple and completes the deployment process, to be run after notarization succeeds

Fixes mapbox/mapbox-gl-native#14753. Reprise of mapbox/mapbox-gl-native#14754.

/cc @mapbox/maps-ios @frederoni

@1ec5
Copy link
Contributor Author

1ec5 commented Mar 10, 2020

Set ENABLE_HARDENED_RUNTIME=YES in invocations of xcodebuild in package.sh (as opposed to inside the project, so non–Mapbox team members can continue to build ad-hoc)

I ended up moving this setting to the project. It seems to be possible to build the application ad-hoc with the hardened runtime setting after all.

@nishant-karajgikar nishant-karajgikar mentioned this pull request Mar 30, 2020
@1ec5 1ec5 force-pushed the 1ec5-macos-notarized branch 2 times, most recently from 8c588ca to 7b3b84f Compare April 8, 2020 05:56
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 8, 2020

I ended up moving this setting to the project. It seems to be possible to build the application ad-hoc with the hardened runtime setting after all.

But then macosapp won’t run in the debugger. So I limited the hardened runtime setting to the Release configuration for now, but I’ll probably go back to setting the build setting in a script once everything is fully automated.

@1ec5 1ec5 force-pushed the 1ec5-macos-notarized branch 3 times, most recently from b0e2d3a to 4e5d593 Compare May 2, 2020 00:44
@stale stale bot added the archived label Jul 10, 2020
@stale
Copy link

stale bot commented Jul 11, 2020

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notarize macosapp
1 participant