Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Deprecate MapboxMap#cycleDebugOptions #104

Merged
merged 1 commit into from
Dec 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Mapbox welcomes participation and contributions from everyone. If you'd like to
## master
### Bug fixes
- Fixed a crash caused by an unintentional minification of the `LocalGlyphRasterizer`. [#102](https://github.com/mapbox/mapbox-gl-native-android/pull/102)
- Deprecated `MapboxMap#cycleDebugOptions` and fixed an `UnsatisfiedLinkError` when accessed. [#104](https://github.com/mapbox/mapbox-gl-native-android/pull/104)

## 8.6.0-beta.1 - December 6, 2019
[Changes](https://github.com/mapbox/mapbox-gl-native/compare/android-v8.6.0-alpha.2...android-v8.6.0-beta.1) since [Mapbox Maps SDK for Android v8.6.0-alpha.2](https://github.com/mapbox/mapbox-gl-native/releases/tag/android-v8.6.0-alpha.2):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -775,10 +775,12 @@ public void setDebugActive(boolean debugActive) {
* any map debug options enabled or disabled.
*
* @see #isDebugActive()
* @deprecated use {@link #setDebugActive(boolean)}
*/
@Deprecated
public void cycleDebugOptions() {
nativeMapView.cycleDebugOptions();
this.debugActive = nativeMapView.getDebug();
this.debugActive = !nativeMapView.getDebug();
nativeMapView.setDebug(debugActive);
}

//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,6 @@ List<Feature> queryRenderedFeatures(@NonNull RectF coordinates,

boolean getDebug();

void cycleDebugOptions();

void setReachability(boolean status);

void setApiBaseUrl(String baseUrl);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -583,14 +583,6 @@ public void setDebug(boolean debug) {
nativeSetDebug(debug);
}

@Override
public void cycleDebugOptions() {
if (checkState("cycleDebugOptions")) {
return;
}
nativeCycleDebugOptions();
}

@Override
public boolean getDebug() {
if (checkState("getDebug")) {
Expand Down Expand Up @@ -1263,9 +1255,6 @@ private native void nativeSetVisibleCoordinateBounds(LatLng[] coordinates, RectF
@Keep
private native void nativeSetDebug(boolean debug);

@Keep
private native void nativeCycleDebugOptions();

@Keep
private native boolean nativeGetDebug();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ private void setupDebugChangeView() {
FloatingActionButton fabDebug = findViewById(R.id.fabDebug);
fabDebug.setOnClickListener(view -> {
if (mapboxMap != null) {
mapboxMap.setDebugActive(!mapboxMap.isDebugActive());
Timber.d("Debug FAB: isDebug Active? %s", mapboxMap.isDebugActive());
mapboxMap.cycleDebugOptions();
}
});
}
Expand Down