Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only localize layers based on Mapbox Streets source #3

Closed
1ec5 opened this issue May 16, 2017 · 1 comment
Closed

Only localize layers based on Mapbox Streets source #3

1ec5 opened this issue May 16, 2017 · 1 comment

Comments

@1ec5
Copy link
Contributor

1ec5 commented May 16, 2017

If the developer has brought in another source for data visualization purposes, it may well have a name property that’s unrelated to the one in the Mapbox Streets source. This plugin should only touch layers using the Mapbox Streets source. Alternatively, it should offer a way for the developer to map languages to name properties in their non-Streets sources.

This Objective-C code targeting the macOS SDK returns true if a vector source’s URL is a mapbox: URL containing mapbox.mapbox-streets-v7. (A straight-up string comparison won’t work due to compositing.)

/ref mapbox/mapbox-gl-native#7031
/cc @lukasmartinelli

@lukasmartinelli
Copy link
Contributor

You are just too fast Minh :)
Need to implement all of these 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants