Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra geolocate control private method documentation #9754

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

andrewharvey
Copy link
Collaborator

Launch Checklist

  • briefly describe the changes in this PR

since I don't think I'll get to #8929 anytime soon, I've pulled out some of the unrelated JSDoc fixes and additions for some private methods.

@andrewharvey andrewharvey added the skip changelog Used for PRs that do not need a changelog entry label Jun 3, 2020
* geolocation support is not available, the GeolocateControl will not
* be visible.
* geolocation support is not available, the GeolocateControl will show
* as disabled.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behaviour was changed in #8871

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mourner mourner merged commit 305f4bc into master Jun 3, 2020
@mourner mourner deleted the aharvey-jsdoc-fixes branch June 3, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants