Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-danube] v1.10.1 #9684

Merged
merged 6 commits into from
May 14, 2020
Merged

[release-danube] v1.10.1 #9684

merged 6 commits into from
May 14, 2020

Conversation

karimnaaji
Copy link
Contributor

@karimnaaji karimnaaji commented May 13, 2020 •
edited
Loading

zmiao and others added 2 commits May 13, 2020 09:29
@zmiao @karimnaaji
Fix using within expression with complex filter (#9611)
2547bce 
* Fix within usage with othere expressions in the same filter

* Add render tests

* Fix filter operator checking for nested condition
@karimnaaji
Fix image expression (#9668)
e9863e4
@karimnaaji karimnaaji marked this pull request as draft May 13, 2020 16:36
ansis added 3 commits May 13, 2020 11:06
@ansis @karimnaaji
fix #9676, fire touchmove event while handlers are active (#9685)
1f1b8a5
@ansis @karimnaaji
map.isMoving() match move events fix #9647 (#9679)
3b39c58 
* map.isMoving() match move events fix #9647

Previously isMoving() would return true if any interaction handler was
active. Handlers are sometimes active even if they haven't changed the
map yet. This resulted in the isMoving() returning true when the map
hasn't moved.

This makes isMoving aligned with movestart/move/moveend events.

Since move events may be fired after several mouse events have been
batched, the camera changes a mouseevent will *later* cause won't be
reflected in isMoving() when that mouseevent is fired.

* lint

* fix test
@ansis @karimnaaji
fix pinching while touching markers (#9683)
c8c4f87 
* fix multi-finger gestures touching markers

Previously we were using e.targetTouches as the list of touches relevant
to the map. It contains only the touches that first touched the same
target. Touches that hit a marker have a different target.

This fixes uses e.touches and filters out touches who's target is not a
child of the map.

fix #9675

* update tests and add regression test
@karimnaaji karimnaaji marked this pull request as ready for review May 14, 2020 17:23
@karimnaaji karimnaaji requested a review from a team May 14, 2020 17:23
@karimnaaji @mannnick24
Review nits: set an interim paint in style_layer (#9688)
ef0884e 
* set an interim paint in style_layer

* add a simple test for undefined paint

* Address review nits

* Silence inconsistent flow error

Co-authored-by: Nick Mann <nick_j_mann@uk.ibm.com>
@karimnaaji karimnaaji merged commit 0a5c510 into release-danube May 14, 2020
@karimnaaji karimnaaji deleted the release-danube-patch branch May 14, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karimnaaji @asheemmamoowala @zmiao @ansis