Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern attributes 4-bytes alignment #9681

Merged
merged 3 commits into from
May 14, 2020
Merged

Pattern attributes 4-bytes alignment #9681

merged 3 commits into from
May 14, 2020

Commits on May 12, 2020

  1. Align pattern_attributes to 4-bytes boundaries 

    This was reported as being an issue on failed render tests on AMD graphics cards
    @karimnaaji
    karimnaaji committed May 12, 2020
    Configuration menu
    Copy the full SHA
    faf8ba7 View commit details
    Browse the repository at this point in the history

  2. Warn on 4-bytes misalignment 

    $ yarn run codegen
Warning: The layout StructArrayLayout3ui6 is not aligned to 4-bytes boundaries.
Warning: The layout StructArrayLayout3i6 is not aligned to 4-bytes boundaries.
Warning: The layout StructArrayLayout3ui6 is not aligned to 4-bytes boundaries.
Warning: The layout StructArrayLayout1ui2 is not aligned to 4-bytes boundaries.
    @karimnaaji
    karimnaaji committed May 12, 2020
    Configuration menu
    Copy the full SHA
    d2718b5 View commit details
    Browse the repository at this point in the history

  3. Exclude non-deterministic test from render tests harness 

    This test is non-deterministic on AMD, slight offset in the pattern. Excluding until root cause can be identified
on this hardware
    @karimnaaji
    karimnaaji committed May 12, 2020
    Configuration menu
    Copy the full SHA
    d80dc14 View commit details
    Browse the repository at this point in the history