Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 9518 #9520

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Fix for issue 9518 #9520

merged 2 commits into from
Apr 9, 2020

Commits on Apr 9, 2020

  1. Add regression test for #9518

    @karimnaaji
    karimnaaji committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1a036c8 View commit details
    Browse the repository at this point in the history

  2. More thorough input checks for isPatternMissing function 

    Fixes regression introduced by #9380

ResolvedImage.fromString may now return null, which potentially leaves CrossFaded<ResolvedImage>
with missing image patterns

I have traced other code paths using ResolvedImage.fromString and have not seen
any other potential offenders
    @karimnaaji
    karimnaaji committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    2f1d175 View commit details
    Browse the repository at this point in the history