Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify node version 8 or 10 #9389

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Specify node version 8 or 10 #9389

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b5fe62
Specify nove version 8 or 10
Mar 7, 2020
38e426f
Node v10 only
Mar 9, 2020
46b038f
Update CONTRIBUTING.md
Mar 9, 2020
02b27f1
Update CONTRIBUTING.md
Mar 9, 2020
49b49ee
Update CONTRIBUTING.md
Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Install the Xcode Command Line Tools Package
xcode-select --install
```

Install [node.js](https://nodejs.org/) version 4 or greater
Install [node.js](https://nodejs.org/) version 10
asheemmamoowala marked this conversation as resolved.
Show resolved Hide resolved
```bash
brew install node
```
Expand All @@ -31,7 +31,7 @@ yarn install

### Linux

Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 6 or greater), [GNU Make](http://www.gnu.org/software/make/), and libglew-dev
Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 10), [GNU Make](http://www.gnu.org/software/make/), and libglew-dev
asheemmamoowala marked this conversation as resolved.
Show resolved Hide resolved
```bash
sudo apt-get update &&
sudo apt-get install build-essential git nodejs libglew-dev libxi-dev
Expand All @@ -56,7 +56,7 @@ yarn install

### Windows

Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 4 or greater), [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules).
Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) (version 10), [yarn](https://yarnpkg.com/en/docs/install#windows-tab), [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules).
asheemmamoowala marked this conversation as resolved.
Show resolved Hide resolved

Clone the repository
```bash
Expand Down