Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent creation of unused depth renderbuffer attachments #9377

Merged
merged 4 commits into from
Mar 5, 2020
Merged

Prevent creation of unused depth renderbuffer attachments #9377

merged 4 commits into from
Mar 5, 2020

Commits on Mar 4, 2020

  1. Remove unused depth renderbuffer 

    Should save width * height * 2 bytes of uncompressed buffer memory
    @karimnaaji
    karimnaaji committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    57bb5b6 View commit details
    Browse the repository at this point in the history

  2. Prevent creation of unused depth renderbuffers 

    Add option to allow not creating extra renderbuffers
Refer https://www.khronos.org/registry/webgl/specs/latest/1.0/\#6.8 for supported attachment variants
Should save the hillshade offscreen buffer width * height * 2 bytes of uncompressed gpu memory
    @karimnaaji
    karimnaaji committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    8fd1ec3 View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @karimnaaji
    karimnaaji committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    05edd13 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Update src/gl/framebuffer.js 

    Co-Authored-By: Vladimir Agafonkin <agafonkin@gmail.com>
    @karimnaaji @mourner
    karimnaaji and mourner authored Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0364b0c View commit details
    Browse the repository at this point in the history