Raster optimization: how deep to lookup for parent for fade #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raster optimization: how deep to lookup for parent for fade
Avoid sequential lookup from current zoom all the way to zoom level 0 as it affects performance.
Do the same approach as used in SourceCache.update when calculating retained raster tiles `const minCoveringZoom = Math.max(idealZ - SourceCache.maxOverzooming, sourceCache.getSource().minzoom);`.
If layer.paint.get('raster-fade-duration') is 0, no need to calculate parent since it is anyway ignored in getFadeValues.
|
Closing this temporarily while re-verifying the impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid sequential lookup from current zoom all the way to zoom level 0 as it affects performance.
Do the same approach as used in SourceCache.update when calculating retained raster tiles
const minCoveringZoom = Math.max(idealZ - SourceCache.maxOverzooming, sourceCache.getSource().minzoom);.If layer.paint.get('raster-fade-duration') is 0, no need to calculate parent since it is anyway ignored in getFadeValues.
The optimization is done based on measurements in #8979 (comment)
Before the patch:
After the patch: