Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add condition for rotate and pitch events #8869

Closed
wants to merge 1 commit into from
Closed

add condition for rotate and pitch events #8869

wants to merge 1 commit into from

Conversation

cs09g
Copy link
Contributor

@cs09g cs09g commented Oct 14, 2019

This is a fix for #8842. It works as expected in a browser. But, unfortunately, tests couldn't make the map move so are failed.
Is this the right way? Any suggestions are welcome!

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page

@mourner
Copy link
Member

mourner commented Oct 15, 2019

Closing in favor of #8872, but thanks a lot for the attempt!

@mourner mourner closed this Oct 15, 2019
@cs09g cs09g deleted the fix-1 branch October 15, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants