fix #8705 actor error after map is removed #8711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a tile was reloaded shortly before a `map.remove()`, raster tiles that were in the middle of being loaded would not be aborted leading to an error when the tried to work with the removed map. The problem applies to removing and reloading tile.
mourner
approved these changes
Aug 30, 2019
mourner
pushed a commit
that referenced
this pull request
Sep 4, 2019
If a tile was reloaded shortly before a `map.remove()`, raster tiles that were in the middle of being loaded would not be aborted leading to an error when the tried to work with the removed map. The problem applies to removing and reloading tile.
mourner
added a commit
that referenced
this pull request
Sep 4, 2019
If a tile was reloaded shortly before a `map.remove()`, raster tiles that were in the middle of being loaded would not be aborted leading to an error when the tried to work with the removed map. The problem applies to removing and reloading tile.
stepankuzmin
pushed a commit
to stepankuzmin/mapbox-gl-js
that referenced
this pull request
Sep 9, 2019
If a tile was reloaded shortly before a `map.remove()`, raster tiles that were in the middle of being loaded would not be aborted leading to an error when the tried to work with the removed map. The problem applies to removing and reloading tile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #8705. I was able to reproduce that error only with
map.style._reloadSource('mapbox'); map.remove();ondebug/satellite.htmlIf a tile was reloaded shortly before a
map.remove(), raster tiles that were in the middle of being loaded would not be aborted leading to an error when the tried to work with the removed map.The broader problem happens whenever a tile is removed while it is being reloaded.
Overall all the code that deals with tile state and map removing seems very brittle and something worth looking at for a refactor.
I'm not sure how to test this.
Launch Checklist