Enable variable placement with allowed text overlap #8620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
reviewed
Aug 12, 2019
There was a problem hiding this comment.
It looks like this checks for collision in the case where there is one anchor and overlap is allowed. Do you think it would be worth implementing this so that it doesn't start doing placement in these cases? I'm wondering if this might be a significant performance change for maps with a ton of overlapping markers.
ansis
approved these changes
Aug 12, 2019
|
@ansis thanks for review! |
This was referenced Aug 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine is trying to place the text first, and allows collision only if there is no position without a collision.
Fixes: #8527