-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable vertical point label placement via 'text-writing-mode' style property #8399
Commits on Jul 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 17d5b2c - Browse repository at this point
Copy the full SHA 17d5b2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b757541 - Browse repository at this point
Copy the full SHA b757541View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49b5e22 - Browse repository at this point
Copy the full SHA 49b5e22View commit details -
Revert "Skip render tests for text-writing-mode property"
This reverts commit 069c6f0.
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for f42fdc0 - Browse repository at this point
Copy the full SHA f42fdc0View commit details -
Add 'text-writing-mode' style spec type & symbol layer prop
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 301b237 - Browse repository at this point
Copy the full SHA 301b237View commit details -
Add attributes to SymbolInstance & PlacedSymbol structs for vertical …
…placement - Add placedOrientation attribute to PlacedSymbol - Add verticalTextBox attributes to SymbolInstance alongside textBox & iconBox
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 5543064 - Browse repository at this point
Copy the full SHA 5543064View commit details -
Rotate glyphs for vertical point labels if needed & correct for y-offset
Port changes from gl-native@alexshalamov_wip_vertical_labels (shaping.cpp, quads.cpp glyphs.hpp)
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for ee80a96 - Browse repository at this point
Copy the full SHA ee80a96View commit details -
Track writing modes and enable vertical placement in SymbolBucket
- Add writingModes and allowVerticalPlacement properties to SymbolBucket - Compute writingModes from `text-writing-mode` style property - Determine glyph dependencies based on whether vertical placement is allowed - Rotate symbols as needed
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 75afcf6 - Browse repository at this point
Copy the full SHA 75afcf6View commit details -
Track vertical collision boxes in SymbolBucket, if needed
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 1943700 - Browse repository at this point
Copy the full SHA 1943700View commit details -
Add vertical text shaping during symbol layout, if needed
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 82d1add - Browse repository at this point
Copy the full SHA 82d1addView commit details -
Add vertical text collision feature during symbol layout, if needed
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 9efe670 - Browse repository at this point
Copy the full SHA 9efe670View commit details -
Hide unused orientation glyphs when drawing symbols
- Add updateVerticalLabels to hide glyphs for unused orientations - Modify updateVariableAnchors to hide unused orientation glyphs when using vertical labels and variable anchors
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 40728c9 - Browse repository at this point
Copy the full SHA 40728c9View commit details -
Place correct orientation variant per chosen writing modes
- Attempt to place vertical/horizontal boxes for each symbol according to writing mode order of preference - Integrate with variable-anchor placement to try each anchor/orientation combination possible - Prefer previously placed orientations & anchors - Hide unplaced orientations
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for a3a8883 - Browse repository at this point
Copy the full SHA a3a8883View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec6be6a - Browse repository at this point
Copy the full SHA ec6be6aView commit details -
Organize text-writing-mode render tests to separate line/point tests
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 4a7bbdd - Browse repository at this point
Copy the full SHA 4a7bbddView commit details -
Add more render tests for vertical CJK point labels
Add tests for vertical placement of point labels with: - CJK text with punctuation - multiline mixed CJK/latin text - CJK with embedded Arabic RTL text
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 993bcf8 - Browse repository at this point
Copy the full SHA 993bcf8View commit details -
Anjana Vakil committed
Jul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for ff3dda3 - Browse repository at this point
Copy the full SHA ff3dda3View commit details -
Minor fixes per reviewer comments
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 0e3a85a - Browse repository at this point
Copy the full SHA 0e3a85aView commit details -
Revert "Update yarn.lock" per reviewer comment
This reverts commit 3ff7480.
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for a9ff21f - Browse repository at this point
Copy the full SHA a9ff21fView commit details -
Deduplicate values during SymbolStyleLayer creation (not SymbolBucket)
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for ab22573 - Browse repository at this point
Copy the full SHA ab22573View commit details -
Add type annotations for variable anchor box placement
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 51ba9bb - Browse repository at this point
Copy the full SHA 51ba9bbView commit details -
Use .indexOf instead of .includes for IE compat; lint fix
Anjana Vakil committedJul 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 20b8146 - Browse repository at this point
Copy the full SHA 20b8146View commit details
Commits on Aug 1, 2019
-
Render half-width glyphs in upright orientation
This change forces glyphs whose natural orientation in vertical writing mode is 'sideways' to be rendered in upright orientation (only for non complex text layouts). This is different compared to W3C / browser behavior that is by default, renders glyphs in their respective natural orientation. In the future, there might need to add a new layout property that would control glyph orientation separately (e.g., text-glyph-orientation: natural | upright).
Configuration menu - View commit details
-
Copy full SHA for 96c7f22 - Browse repository at this point
Copy the full SHA 96c7f22View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1f6cb4 - Browse repository at this point
Copy the full SHA d1f6cb4View commit details