Placement order matches viewport-y sort #8180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
force-pushed
the
mikhail_sorted_y_placement
branch
from
31b0f7a
to
1d22882
Compare
Symbols are placed accordingly to their viewport Y order, if the style `symbol-z-order` is explicitly set to `viewport-y`. This improves rendering of symbol layers, where icons are allowed to overlap but not text.
pozdnyakov
force-pushed
the
mikhail_sorted_y_placement
branch
from
1d22882
to
d8bc48a
Compare
|
@ansis @asheemmamoowala PTAL |
asheemmamoowala
approved these changes
Apr 29, 2019
There was a problem hiding this comment.
👍 from me, but I think a 👀 from @ansis would still be helpful.
|
|
||
| result.sort((aIndex, bIndex) => { | ||
| return (rotatedYs[aIndex] - rotatedYs[bIndex]) || | ||
| (featureIndexes[bIndex] - featureIndexes[aIndex]); |
There was a problem hiding this comment.
nit: Docs should be updated to include fallback to source order for symbols with same Y. Especially useful is symbol-sort-key is also provided, and the expectation would be to fallback to the sort key.
There was a problem hiding this comment.
Will make a separate PR for that, thanks!
mapbox/mapbox-gl-native#14486 <- the peer PR in gl-native, approved by @ansis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbols are placed accordingly to their viewport Y order,
if the style
symbol-z-orderis explicitly set toviewport-y.This improves rendering of symbol layers, where icons are allowed
to overlap but not text.