Inline test suite dependencies #8151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having integration tests dependencies in their own
package.jsonfile and then fetching them throughfile:dependency in the rootpackage.jsoncauses Yarn to cache a new copy of the suite (136MB) every time Yarn is run, wasting a ton of drive space.Previously, we did it this way so thatI was wrong about that. Let's see if we can find an alternative...mapbox-gl-nativecould avoid installing any other dependencies besides the test suite ones, but that was at the time it usedmapbox-glas a dev dependency — since then, we've switched to using it as a submodule, and it seems like we install all deps anyway.A small additional benefit is that it will be easier to keep the deps up to date and not have different version duplicates between the main repo and the suite.