warn about missing style images #8000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhamley
approved these changes
Mar 6, 2019
ansis
force-pushed
the
missingimagewarning
branch
from
766938b
to
117e60f
Compare
|
Yep, changed to mention |
|
@ansis @ryanhamley does this close #6823? |
|
@chloekraw #6823 is technically asking for something slightly different (warn when the sprite URL is not defined in a style that uses sprite-dependent properties vs warn when an image that is requested is not found) but this might cover the use case well enough for it to be considered closed. @ansis do you think we need specific sprite validation logic? |
|
👍 thanks @ryanhamley, to me it sounds like something that would still be good to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a missing fix to the previous icon pr. Cherry picked from #6831