Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add half float image for heatmap stencil regression test #6812

Closed
wants to merge 1 commit into from

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Jun 13, 2018

Adds half float test (I think — generated in gl-native) for #6807.

Launch Checklist

  • briefly describe the changes in this PR

@lbud lbud requested a review from mourner June 15, 2018 00:00
@mourner
Copy link
Member

mourner commented Jun 15, 2018

image
image

@lbud the images look different — in theory, they should be the same (matching shapes, etc.) except non-half-float having lower "resolution", while the above half-float version is more "intensive". Here's an example from heatmap-color/default of how the difference should look:

image
image

@mourner
Copy link
Member

mourner commented Nov 8, 2018

Looks like we can't merge without figuring out the mismatch so I'm going to close this as stale for now.

@mourner mourner closed this Nov 8, 2018
@asheemmamoowala asheemmamoowala deleted the 6806-half-float branch March 9, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants