Add API to list all images/sprites currently available in the map #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbud
suggested changes
May 18, 2018
test/unit/ui/map.test.js
Outdated
| const data = new Uint8Array(width * width * bytesPerPixel); | ||
| const imageName = 'gradient'; | ||
|
|
||
| for (let x = 0; x < width; x++) { |
There was a problem hiding this comment.
For readability let's simplify this test image to be just a very simple small image (e.g. a 4 channel 1x1px or 2x2px image).
src/render/painter.js
Outdated
| @@ -266,6 +266,14 @@ class Painter { | |||
| return new DepthMode(func || this.context.gl.LEQUAL, mask, [nearDepth, farDepth]); | |||
| } | |||
|
|
|||
| listImages() { | |||
There was a problem hiding this comment.
Although we do technically attach the style's imageManager instance to the Painter, it's more of a member of the Style class, which also manages other ImageManager-related APIs (addImage/getImage/removeImage) — let's move this there.
ryanhamley
force-pushed
the
6381-list-images-api
branch
from
0ca4880
to
62721ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Mapto allow user to list all images/sprites available to the map (via the ImageManager)Closes #6381