Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ["to-string", null] from "null" to "" #6534

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Change ["to-string", null] from "null" to "" #6534

merged 2 commits into from
Apr 18, 2018

Conversation

anandthakker
Copy link
Contributor

Closes #6533

jfirebaugh
jfirebaugh reviewed Apr 18, 2018
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the docs and add this to the changelog as a breaking change (it technically is, but I think unlikely to affect anyone significantly).

@anandthakker anandthakker merged commit d5c5ef5 into master Apr 18, 2018
@anandthakker anandthakker deleted the to-string-null branch April 18, 2018 17:02
@ChrisLoer ChrisLoer mentioned this pull request Apr 23, 2018
Closed
1ec5 pushed a commit that referenced this pull request May 14, 2018
@anandthakker @1ec5
Change ["to-string", null] from "null" to "" (#6534)
cc3bb6a 
* Change ["to-string", null] from "null" to ""

Closes #6533

* Update changelog and style-spec docs

Cherry-picked from d5c5ef5.
@1ec5 1ec5 mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandthakker @jfirebaugh