Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas source initialization from HTML element #6403

Closed
wants to merge 5 commits into from
Closed

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Mar 26, 2018

cc @ryanbaumann

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs (will be autogenerated in mb-pages update)
  • manually test the debug page

@jfirebaugh
Copy link
Contributor

Since the canvas source type is inherently a gl-js-specific concept, should we remove it from v8.json entirely? This was first suggested in #5545.

@lbud
Copy link
Contributor Author

lbud commented Mar 29, 2018

Superseded by #6424.

@lbud lbud closed this Mar 29, 2018
@lbud lbud deleted the canvas-el branch March 29, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas source initialization from HTML element, instead of element id
2 participants