always hide duplicate labels instantly #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLoer
reviewed
Feb 14, 2018
src/symbol/placement.js
Outdated
| opacityState = defaultOpacityState; | ||
| } | ||
|
|
||
| if (!this.opacities[symbolInstance.crossTileID]) { |
There was a problem hiding this comment.
Can't we just move this into the else if (!opacityState) clause above and avoid a second lookup? Because it shouldn't be possible for us to have gone down the isDuplicate branch without having first made an entry for this this.opacities[crossTileID] (and if it were possible, it'd be a problem, because we'd be making our initial entry into duplicateOpacityState instead of defaultOpacityState).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate labels were not always hidden instantly, resulting in the same label being rendered twice by different tiles. This fixes that.
port of mapbox/mapbox-gl-native#11207
Launch Checklist