Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TouchZoomRotate handler to use render-loop-driven camera #6115

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Update TouchZoomRotate handler to use render-loop-driven camera #6115

merged 2 commits into from
Feb 28, 2018

Conversation

anandthakker
Copy link
Contributor

No description provided.

jfirebaugh
jfirebaugh reviewed Feb 14, 2018
View reviewed changes
src/ui/handler/touch_zoom_rotate.js
param.zoom = map.transform.scaleZoom(this._startScale * scale);
}
e.preventDefault();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a this._map._update() like in #6068, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍

@jfirebaugh jfirebaugh mentioned this pull request Feb 26, 2018
Closed
@jfirebaugh jfirebaugh added this to the 0.45.0 milestone Feb 28, 2018
@jfirebaugh jfirebaugh force-pushed the fix-touch-zoom branch 2 times, most recently from 9f3db82 to 74b9904 Compare February 28, 2018 22:17
@jfirebaugh
Copy link
Contributor

I updated this to be consistent with #6171 and added some basic tests that verify that it fixes #6182.

@jfirebaugh jfirebaugh merged commit 18bb520 into master Feb 28, 2018
@jfirebaugh jfirebaugh deleted the fix-touch-zoom branch February 28, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anandthakker @jfirebaugh