Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race condition on ImageSprite load #586

Closed
wants to merge 1 commit into from
Closed

race condition on ImageSprite load #586

wants to merge 1 commit into from

Conversation

jfirebaugh
Copy link
Contributor

If the image takes a long time to load, drawSymbol will produce errors due to trying to use the uninitialized sprite.img.

To reproduce, wrap the ajax.getImage callback in a 5 second setTimeout.

Uncaught TypeError: Failed to execute 'texImage2D' on 'WebGLRenderingContext': No function was found that matched the signature provided. imagesprite.js:75

If you bypass that error by checking sprite.loaded():

Uncaught TypeError: Cannot read property 'width' of undefined drawsymbol.js:60

@jfirebaugh jfirebaugh closed this Jul 21, 2014
@jfirebaugh jfirebaugh deleted the imagesprite-race branch July 21, 2014 20:20
stepankuzmin pushed a commit that referenced this pull request Jun 21, 2023
@jtorresfabra
Fix for incorrect buffer size for index array in model loader (#586)
263c20f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jfirebaugh