Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split "curve" into "step" and "interpolate" #5542

Merged
merged 2 commits into from
Oct 31, 2017
Merged

Conversation

jfirebaugh
Copy link
Contributor

Fixes #5528. Will make sure all the right people get a heads up before this is merged.

@jfirebaugh
Copy link
Contributor Author

Blocked on posting benchmark results by #5543.

Copy link
Contributor

@anandthakker anandthakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

My only question: should we add a "curve" alias (with a loud deprecation warning) and thus postpone the breaking change by one version?

@mourner
Copy link
Member

mourner commented Oct 30, 2017

@anandthakker I'd say no, better break hard early. Alias would be good to help with the transition, but there's not enough adoption of expressions yet to delay the break.

@jfirebaugh
Copy link
Contributor Author

I kept it an error, but with a custom error message indicating the new operators.

@jfirebaugh
Copy link
Contributor Author

@jfirebaugh jfirebaugh merged commit 25e5f1d into master Oct 31, 2017
@jfirebaugh jfirebaugh deleted the curve-step-interpolate branch October 31, 2017 17:23
@jfirebaugh jfirebaugh added this to the v0.42 milestone Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants