Generate flow types from recent style-spec changes #5454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #5449 (comment), that PR failed to remove the
contextType
parameter from theCanvasSourceSpecification
flow type. I ran the build script to generate it and it looks like our type definitions are out of date for a few things. @jfirebaugh or @anandthakker — is it weird that flow testing on local machines/CI hasn't complained about these? 🤔