Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light.anchor: zoom (piecewise-constant) functions supported #4757

Merged
merged 1 commit into from
May 25, 2017
Merged

light.anchor: zoom (piecewise-constant) functions supported #4757

merged 1 commit into from
May 25, 2017

Conversation

lbud
Copy link
Contributor

@lbud lbud commented May 25, 2017

Fixes #4743 by adding appropriate key/value pairs to light.anchor documentation .

@lbud lbud requested a review from 1ec5 May 25, 2017 22:21
jfirebaugh
jfirebaugh approved these changes May 25, 2017
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be targeted at mb-pages so it goes live immediately. Otherwise 👍 .

@lbud
Copy link
Contributor Author

lbud commented May 25, 2017

@jfirebaugh in GL JS current master (and release) this is actually not supported because spec-based validation fails, so I think this would not be appropriate to target mb-pages before the next release.

@lbud lbud merged commit f482f18 into master May 25, 2017
@lbud lbud deleted the 4743-light-anchor-doc branch May 25, 2017 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbud @jfirebaugh